pjfanning commented on code in PR #2001:
URL: https://github.com/apache/pekko/pull/2001#discussion_r2249920373
##########
actor/src/main/scala/org/apache/pekko/pattern/Patterns.scala:
##########
@@ -126,7 +126,8 @@ object Patterns {
* timeout);
* }}}
*/
- def askWithReplyTo(actor: ActorRef, messageFactory: japi.Function[ActorRef,
Any], timeout: Timeout): Future[AnyRef] =
+ def askWithReplyTo(actor: ActorRef, messageFactory:
japi.function.Function[ActorRef, Any], timeout: Timeout)
Review Comment:
I am not aboard with this. This is a breaking change where we did not
deprecate the old code first.
I don't know what is the best way to approach this but I think this change
needs serious debate.
Would it be feasible to have 2 copies of this method? This version and also
the old version but that is marked as deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
