He-Pin commented on code in PR #2001:
URL: https://github.com/apache/pekko/pull/2001#discussion_r2251003172
##########
actor/src/main/scala/org/apache/pekko/pattern/Patterns.scala:
##########
@@ -126,7 +126,8 @@ object Patterns {
* timeout);
* }}}
*/
- def askWithReplyTo(actor: ActorRef, messageFactory: japi.Function[ActorRef,
Any], timeout: Timeout): Future[AnyRef] =
+ def askWithReplyTo(actor: ActorRef, messageFactory:
japi.function.Function[ActorRef, Any], timeout: Timeout)
Review Comment:
@mdedetrich So you mean we depracate this classes in 1.2.x right? thanks.
##########
actor/src/main/scala/org/apache/pekko/pattern/Patterns.scala:
##########
@@ -126,7 +126,8 @@ object Patterns {
* timeout);
* }}}
*/
- def askWithReplyTo(actor: ActorRef, messageFactory: japi.Function[ActorRef,
Any], timeout: Timeout): Future[AnyRef] =
+ def askWithReplyTo(actor: ActorRef, messageFactory:
japi.function.Function[ActorRef, Any], timeout: Timeout)
Review Comment:
@mdedetrich So you mean we depracate these classes in 1.2.x right? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
