pjfanning commented on code in PR #2001:
URL: https://github.com/apache/pekko/pull/2001#discussion_r2249961392
##########
actor/src/main/scala/org/apache/pekko/pattern/Patterns.scala:
##########
@@ -126,7 +126,8 @@ object Patterns {
* timeout);
* }}}
*/
- def askWithReplyTo(actor: ActorRef, messageFactory: japi.Function[ActorRef,
Any], timeout: Timeout): Future[AnyRef] =
+ def askWithReplyTo(actor: ActorRef, messageFactory:
japi.function.Function[ActorRef, Any], timeout: Timeout)
Review Comment:
I'll go with the consensus on this but it would be useful if we knew if
external users will need to rewrite their code that uses our Java stream API
due to this change or if a recompile is enough. I'm making assumptions but if
Java use lambdas already when passing functions to our APIs then a recompile
should be enough. But if they have code that uses japi.Function directly (or
any of the other function classes that are being removed) then the user needs
to do a code rewrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
