He-Pin opened a new pull request, #587: URL: https://github.com/apache/pekko-connectors-kafka/pull/587
### Motivation - `ManualSubscription.rebalanceListener`/`withRebalanceListener` were deprecated since Alpakka Kafka 1.0-RC1 (manual subscriptions never rebalance). - `DrainingControl.shutdown()` was deprecated since Alpakka Kafka 2.0.0 in favor of `drainAndShutdown()`. ### Modification - Remove deprecated `rebalanceListener` and `withRebalanceListener` from `ManualSubscription` trait. Concrete case classes (`Assignment`, `AssignmentWithOffset`, `AssignmentOffsetsForTimes`) already implement `withRebalanceListener` and now inherit `rebalanceListener = None` from the trait. - Simplify `DrainingControl.shutdown()` to delegate to `control.shutdown()` without the deprecated drain-and-wait behavior, making it consistent with other `Control` implementations. ### Result `ManualSubscription` no longer exposes misleading rebalance listener methods. `DrainingControl.shutdown()` delegates consistently with other `Control` methods. ### Tests Not run - deprecated API cleanup ### References None - deprecated API cleanup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
