pjfanning commented on code in PR #587:
URL:
https://github.com/apache/pekko-connectors-kafka/pull/587#discussion_r3525448348
##########
core/src/main/scala/org/apache/pekko/kafka/Subscriptions.scala:
##########
@@ -41,14 +41,7 @@ sealed trait Subscription {
* Kafka-speak for these is "Assignments".
*/
sealed trait ManualSubscription extends Subscription {
-
- /** @deprecated Manual subscriptions never rebalances, since Alpakka Kafka
1.0-RC1 */
- @deprecated("Manual subscription never rebalances", "Alpakka Kafka 1.0-RC1")
def rebalanceListener: Option[ActorRef] = None
Review Comment:
do we need to keep this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
