pjfanning commented on code in PR #587:
URL:
https://github.com/apache/pekko-connectors-kafka/pull/587#discussion_r3525453940
##########
core/src/main/scala/org/apache/pekko/kafka/scaladsl/Consumer.scala:
##########
@@ -109,12 +109,7 @@ object Consumer {
override def stop(): Future[Done] = control.stop()
- @deprecated("Use `drainAndShutdown` for proper shutdown of the stream.",
"Alpakka Kafka 2.0.0")
Review Comment:
I don't mean to revert it but since we are keeping the function, should we
keep the retained function deprecated and continue to encourage users to use
drainAndShutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
