pjfanning commented on code in PR #862:
URL: https://github.com/apache/pekko-grpc/pull/862#discussion_r3851553132
##########
runtime/src/main/scala/org/apache/pekko/grpc/GrpcProtocol.scala:
##########
@@ -127,12 +127,14 @@ object GrpcProtocol {
* Detects which gRPC protocol variant is indicated in a request.
* @return a [[GrpcProtocol]] matching the request mediatype if specified
and known.
*/
+ @inline
Review Comment:
this doesn't work on scala 3 which requires `inline def` - is there a way to
mark this as final instead making it likely that the JIT compiler will do the
inlining for us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
