timw commented on code in PR #862: URL: https://github.com/apache/pekko-grpc/pull/862#discussion_r3851698272
########## benchmarks/src/main/protobuf/helloworld.proto: ########## @@ -0,0 +1,64 @@ +//#walkthrough +syntax = "proto3"; Review Comment: I couldn't find an example for this (every other helloworld.proto in the codebase doesn't have a license header)... ########## benchmarks/src/main/scala/org/apache/pekko/grpc/AbstractHandlerBenchmark.scala: ########## @@ -0,0 +1,65 @@ +package org.apache.pekko.grpc Review Comment: Will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
