pjfanning commented on code in PR #862:
URL: https://github.com/apache/pekko-grpc/pull/862#discussion_r3851900240
##########
runtime/src/main/scala/org/apache/pekko/grpc/GrpcProtocol.scala:
##########
@@ -127,12 +127,14 @@ object GrpcProtocol {
* Detects which gRPC protocol variant is indicated in a request.
* @return a [[GrpcProtocol]] matching the request mediatype if specified
and known.
*/
+ @inline
Review Comment:
ignore my point about `final` unless we do genuinely think that these
methods should be overridden and then it does make sense to mark them final
I'd prefer to remove the `@inline` unless the JMH proves that they help - my
hope is that JIT compiler will optimise for us and it can usually be relied on
but JMH is the real check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
