He-Pin opened a new pull request, #3727:
URL: https://github.com/apache/pekko/pull/3727

   ### Motivation
   
   The TCP TLS echo test uses `takeWhile` to stop reading the request and 
expects the complete `hello` response before the connection closes. Its default 
`IgnoreComplete` policy also responds to that cancellation, which is allowed to 
discard pending plaintext. On current main, the GraphStage engine returns 
`hell` while the legacy engine happens to pass.
   
   ### Modification
   
   Select `IgnoreCancel` for the test server through the existing overload, 
matching the server use case documented by `TLSClosing` and the shared TLS 
`CancellingRHS` test. Keep the complete-response and stream-completion 
assertions.
   
   ### Result
   
   Both engines send the full response before plaintext-input completion closes 
TLS. Production cancellation semantics are unchanged.
   
   ### Tests
   
   - JDK 21: existing `TcpSpec -- -z "TLS client and server"` failed with 
`graph-stage` before the change and passes afterwards.
   - The same test passes with `legacy-actor`.
   - A separate real-TCP probe on unchanged main with the corrected server 
policy passed 10 times each for TLS 1.2 and TLS 1.3.
   - Native scalafmt, `headerCreateAll`, `+headerCheckAll`, and `git diff 
--check` passed.
   - Full PR validation is delegated to remote CI.
   
   ### References
   
   Refs #2860
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to