He-Pin commented on code in PR #3727:
URL: https://github.com/apache/pekko/pull/3727#discussion_r4407181817
##########
stream-tests/src/test/scala/org/apache/pekko/stream/io/TcpSpec.scala:
##########
@@ -923,7 +923,14 @@ class TcpSpec extends StreamSpec("""
Flow[ByteString].mapConcat(_.utf8String.toList).takeWhile(_ !=
'\n').map(c => ByteString(c)),
address.getHostName,
address.getPort,
- () => createSSLEngine(TLSRole.server))
+ () => createSSLEngine(TLSRole.server),
+ backlog = 100,
+ options = Nil,
+ idleTimeout = Duration.Inf,
+ verifySession = _ => scala.util.Success(()),
+ // takeWhile cancels its input before the response has necessarily
been encrypted.
+ // Finish sending the response before completing the TLS plaintext
input closes the connection.
+ closing = IgnoreCancel)
Review Comment:
Restored the original closing policy. ac631bbc27 adds deterministic
cancellation, handshake, transport-cancellation, and delayed-cancellation
termination tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
