He-Pin commented on code in PR #3727:
URL: https://github.com/apache/pekko/pull/3727#discussion_r4407180619
##########
stream-tests/src/test/scala/org/apache/pekko/stream/io/TcpSpec.scala:
##########
@@ -923,7 +923,14 @@ class TcpSpec extends StreamSpec("""
Flow[ByteString].mapConcat(_.utf8String.toList).takeWhile(_ !=
'\n').map(c => ByteString(c)),
address.getHostName,
address.getPort,
- () => createSSLEngine(TLSRole.server))
+ () => createSSLEngine(TLSRole.server),
Review Comment:
Restored the four-argument overload and fixed the GraphStage cancellation
path in ac631bbc27. The original complete `hello` assertion now passes.
##########
stream-tests/src/test/scala/org/apache/pekko/stream/io/TcpSpec.scala:
##########
@@ -923,7 +923,14 @@ class TcpSpec extends StreamSpec("""
Flow[ByteString].mapConcat(_.utf8String.toList).takeWhile(_ !=
'\n').map(c => ByteString(c)),
address.getHostName,
address.getPort,
- () => createSSLEngine(TLSRole.server))
+ () => createSSLEngine(TLSRole.server),
+ backlog = 100,
Review Comment:
Removed the copied defaults by restoring the original four-argument call in
ac631bbc27.
##########
stream-tests/src/test/scala/org/apache/pekko/stream/io/TcpSpec.scala:
##########
@@ -923,7 +923,14 @@ class TcpSpec extends StreamSpec("""
Flow[ByteString].mapConcat(_.utf8String.toList).takeWhile(_ !=
'\n').map(c => ByteString(c)),
address.getHostName,
address.getPort,
- () => createSSLEngine(TLSRole.server))
+ () => createSSLEngine(TLSRole.server),
+ backlog = 100,
+ options = Nil,
+ idleTimeout = Duration.Inf,
+ verifySession = _ => scala.util.Success(()),
+ // takeWhile cancels its input before the response has necessarily
been encrypted.
+ // Finish sending the response before completing the TLS plaintext
input closes the connection.
Review Comment:
Removed the workaround and its comment. ac631bbc27 drains accepted
current-session plaintext before closing, subject to transport availability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
