[
https://issues.apache.org/jira/browse/RYA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227506#comment-16227506
]
ASF GitHub Bot commented on RYA-356:
------------------------------------
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148107974
--- Diff:
extras/periodic.notification/api/src/main/java/org/apache/rya/periodic/notification/api/PeriodicNotificationClient.java
---
@@ -36,29 +36,26 @@
* Adds a new notification to be registered with the {@link
NotificationCoordinatorExecutor}
* @param notification - notification to be added
*/
- public void addNotification(PeriodicNotification notification);
--- End diff --
Not thrilled about removing public from the interface method headers. I
understand that it is redundant, but I think that most style guides suggest
that you include the public declaration. Also, I think that pretty much all
interfaces within Rya explicitly declare their methods as public.
> Wrap the Periodic NotificationService in a Twill App
> ----------------------------------------------------
>
> Key: RYA-356
> URL: https://issues.apache.org/jira/browse/RYA-356
> Project: Rya
> Issue Type: Sub-task
> Components: clients
> Affects Versions: 3.2.11
> Reporter: Jeff Dasch
> Assignee: Jeff Dasch
> Fix For: 3.2.12
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
