[
https://issues.apache.org/jira/browse/RYA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234133#comment-16234133
]
ASF GitHub Bot commented on RYA-356:
------------------------------------
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148272970
--- Diff:
extras/periodic.notification/api/src/main/java/org/apache/rya/periodic/notification/api/PeriodicNotificationClient.java
---
@@ -36,29 +36,26 @@
* Adds a new notification to be registered with the {@link
NotificationCoordinatorExecutor}
* @param notification - notification to be added
*/
- public void addNotification(PeriodicNotification notification);
--- End diff --
Per the
[JLS](https://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.4):
"It is permitted, but discouraged as a matter of style, to redundantly specify
the public and/or abstract modifier for a method declared in an interface."
This is consistent with how Java and Guava style their code. I realize that
other Rya interfaces may have these redundant modifiers, but I was just
correcting this instance because I was already modifying that file.
> Wrap the Periodic NotificationService in a Twill App
> ----------------------------------------------------
>
> Key: RYA-356
> URL: https://issues.apache.org/jira/browse/RYA-356
> Project: Rya
> Issue Type: Sub-task
> Components: clients
> Affects Versions: 3.2.11
> Reporter: Jeff Dasch
> Assignee: Jeff Dasch
> Priority: Major
> Fix For: 3.2.12
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
