[
https://issues.apache.org/jira/browse/RYA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234629#comment-16234629
]
ASF GitHub Bot commented on RYA-356:
------------------------------------
Github user meiercaleb commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/248#discussion_r148363484
--- Diff:
extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application/PeriodicNotificationApplicationConfiguration.java
---
@@ -85,170 +85,170 @@ public
PeriodicNotificationApplicationConfiguration(Properties props) {
setPrunerThreads(Integer.parseInt(props.getProperty(PRUNER_THREADS,
"1")));
setCoordinatorThreads(Integer.parseInt(props.getProperty(COORDINATOR_THREADS,
"1")));
}
-
+
/**
* Sets the name of the Fluo Application
- * @param fluoAppName
+ * @param fluoAppName
*/
- public void setFluoAppName(String fluoAppName) {
- set(FLUO_APP_NAME, Preconditions.checkNotNull(fluoAppName));
+ public void setFluoAppName(final String fluoAppName) {
+ set(FLUO_APP_NAME, Objects.requireNonNull(fluoAppName));
--- End diff --
I think it's funny that you are advocating leaving out the public modifier
for the your interface methods to eliminate redundancy, yet here you think that
the redundancy is okay. Ironically, the public modifier only costs you 7 chars
as well, and I think you get an equal amount of readility/info out of that.
> Wrap the Periodic NotificationService in a Twill App
> ----------------------------------------------------
>
> Key: RYA-356
> URL: https://issues.apache.org/jira/browse/RYA-356
> Project: Rya
> Issue Type: Sub-task
> Components: clients
> Affects Versions: 3.2.11
> Reporter: Jeff Dasch
> Assignee: Jeff Dasch
> Priority: Major
> Fix For: 3.2.12
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
