funky-eyes commented on code in PR #6325:
URL: https://github.com/apache/incubator-seata/pull/6325#discussion_r1477336837
##########
test/src/test/java/org/apache/seata/core/rpc/netty/mockserver/MockServerTest.java:
##########
@@ -32,42 +32,44 @@ public class MockServerTest {
static String RESOURCE_ID = "mock-action";
+ private static volatile boolean inited = false;
+
@BeforeAll
public static void before() {
MockServer.start();
}
- @AfterAll
+// @AfterAll
public static void after() {
MockServer.close();
Review Comment:
why not close?
##########
test/src/test/java/org/apache/seata/core/rpc/netty/mockserver/MockServerTest.java:
##########
@@ -91,7 +93,7 @@ private static String doTestRollback(int times) throws
TransactionException {
MockCoordinator.getInstance().setExpectedRetry(xid, times);
Long branchId = rm.branchRegister(BranchType.AT, RESOURCE_ID, "1",
xid, "1", "1");
GlobalStatus rollback = tm.rollback(xid);
- Assertions.assertEquals(rollback, GlobalStatus.Rollbacked);
+ Assertions.assertTrue(rollback == GlobalStatus.Rollbacked || rollback
== GlobalStatus.Finished);
Review Comment:
why status is Finished?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
