funky-eyes commented on code in PR #6325: URL: https://github.com/apache/incubator-seata/pull/6325#discussion_r1495172747
########## test/src/test/java/org/apache/seata/common/ConfigurationTestHelper.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common; + +import org.apache.commons.lang.ObjectUtils; +import org.apache.seata.config.ConfigurationCache; +import org.apache.seata.config.ConfigurationFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * the type ConfigurationTestHelper + **/ +public class ConfigurationTestHelper { + + private static final Logger LOGGER = LoggerFactory.getLogger(ConfigurationTestHelper.class); + private static final long PUT_CONFIG_TIMEOUT = 30000L; + private static final long PUT_CONFIG_CHECK_GAP = 500L; + + public static void removeConfig(String dataId) { + putConfig(dataId, null); + } + + public static void putConfig(String dataId, String content) { + ConfigurationCache.addConfigListener(ConfigurationKeys.SERVER_SERVICE_PORT_CAMEL); + if (content == null) { + System.clearProperty(dataId); + ConfigurationFactory.getInstance().removeConfig(dataId); + return; + } + + System.setProperty(dataId, content); + ConfigurationFactory.getInstance().putConfig(dataId, content); + + long start = System.currentTimeMillis(); + while (!ObjectUtils.equals(content, ConfigurationFactory.getInstance().getConfig(dataId))) { Review Comment: > 这里的等待是等缓存刷新，不是并发次数控制，所以用CountDownLatch没用吧 你建立了一个listener，CountDownLatch的countDown动作放在listener实现里，外面这个地方进行等待，就不需要while了。 You create a listener, the CountDownLatch's countDown action is placed in the listener implementation, and this place outside does the waiting, eliminating the need for while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
