slievrly commented on code in PR #6325: URL: https://github.com/apache/incubator-seata/pull/6325#discussion_r1479157526
########## test/src/test/java/org/apache/seata/common/ConfigurationTestHelper.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.common; + +import org.apache.commons.lang.ObjectUtils; +import org.apache.seata.config.ConfigurationCache; +import org.apache.seata.config.ConfigurationFactory; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * the type ConfigurationTestHelper + **/ +public class ConfigurationTestHelper { + + private static final Logger LOGGER = LoggerFactory.getLogger(ConfigurationTestHelper.class); + + + private static final long PUT_CONFIG_TIMEOUT = 30000L; + private static final long PUT_CONFIG_CHECK_GAP = 500L; + + public static void removeConfig(String dataId) { + putConfig(dataId, null); + } + + public static void putConfig(String dataId, String content) { Review Comment: You want to understand what the purpose of mock-server is? Connecting to the Seata-Server as if using a normal SDK eliminates the cumbersome Seata-Server setup, which is useful for testing client integration. If the user gets this mock-server, need to write such complex logic to test it, what is the point of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
