funky-eyes commented on code in PR #6420:
URL: https://github.com/apache/incubator-seata/pull/6420#discussion_r1527539183
##########
config/seata-config-etcd3/src/main/java/org/apache/seata/config/etcd3/EtcdConfiguration.java:
##########
@@ -394,7 +394,7 @@ public void onNext(WatchResponse watchResponse) {
List<KeyValue> keyValues = getResponse.getKvs();
if (CollectionUtils.isNotEmpty(keyValues)) {
event.setDataId(dataId).setNewValue(keyValues.get(0).getValue().toString(UTF_8));
- listener.onChangeEvent(event);
+ listener.onProcessEvent(event);
Review Comment:
> What I am defining here is the interface standard, and what users rely on
is also the interface, which is the basic polymorphic pattern of
object-oriented programming. Is there a good method that would allow us to
inversely constrain user implementations?
Perhaps we can keep the behavior of onChangeEvent consistent with that of
onProcessEvent and add a new method to replace the behavior of the original
onChangeEvent?
或许我们可以将onChangeEvent的行为保持和onProcessEvent一致,新增一个方法来代替原来的onChangeEvent的行为?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
