funky-eyes commented on code in PR #6420:
URL: https://github.com/apache/incubator-seata/pull/6420#discussion_r1527752259
##########
config/seata-config-etcd3/src/main/java/org/apache/seata/config/etcd3/EtcdConfiguration.java:
##########
@@ -394,7 +394,7 @@ public void onNext(WatchResponse watchResponse) {
List<KeyValue> keyValues = getResponse.getKvs();
if (CollectionUtils.isNotEmpty(keyValues)) {
event.setDataId(dataId).setNewValue(keyValues.get(0).getValue().toString(UTF_8));
- listener.onChangeEvent(event);
+ listener.onProcessEvent(event);
Review Comment:
Because the configuration is mainly used by seata, not the user, if this
change can't make the user-side implementation behave the same as our
implementation, it will affect the question of whether the configuration is
effective in seata or not. So this should be a strong constraint setting, all
notifications should go onProcessEvent behavior, otherwise the user's extension
will lose a lot of functionality without perception
因为配置主要是由seata使用，并不是用户使用，如果这个改动无法让用户侧的实现跟我们的实现行为一致，这将影响到配置在seata中是否生效的问题。所以这块应该是强约束的设定，所有的通知应该都走onProcessEvent这个行为，否则用户的扩展将在无感知的情况下丧失很多功能
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
