slievrly commented on code in PR #6420:
URL: https://github.com/apache/incubator-seata/pull/6420#discussion_r1527554724
##########
config/seata-config-etcd3/src/main/java/org/apache/seata/config/etcd3/EtcdConfiguration.java:
##########
@@ -394,7 +394,7 @@ public void onNext(WatchResponse watchResponse) {
List<KeyValue> keyValues = getResponse.getKvs();
if (CollectionUtils.isNotEmpty(keyValues)) {
event.setDataId(dataId).setNewValue(keyValues.get(0).getValue().toString(UTF_8));
- listener.onChangeEvent(event);
+ listener.onProcessEvent(event);
Review Comment:
The original configuration center had two methods of invocation:
onChangeEvent and onProcessEvent. Which do you think should be the standard?
The current changes have unified all previous onChangeEvent calls to
onProcessEvent. What kind of expectations do you think this has for user
behavior? For users to extend on their own, it means they need to understand
structurally the presence or absence of cache, as well as the difference
between synchronous and asynchronous operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
