TeslaCN commented on code in PR #23550:
URL: https://github.com/apache/shardingsphere/pull/23550#discussion_r1089607062
##########
pom.xml:
##########
@@ -944,7 +945,7 @@
<version>${maven.version.range}</version>
</requireMavenVersion>
<requireJavaVersion>
- <version>${java.version}</version>
+ <version>${compile.java.version}</version>
Review Comment:
Hi @zhfeng
I prefer to set `8` as `requireJavaVersion`. Java 11 is required only when
compiling parser modules.
Sometimes we just need to compile a part of modules (such as protocol,
agent), build an image, do some tests, which could be done using Java 8. Adding
`-Denforcer.skip=true` is not elegant.
And the error of compiling antlr 4.10+ with Java 8 is clear enough for
developers.
We could clarify Java requirement in
[Wiki](https://github.com/apache/shardingsphere/wiki) and
[docs](https://shardingsphere.apache.org/community/en/involved/contribute/dev-env/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
