zhfeng commented on PR #23550: URL: https://github.com/apache/shardingsphere/pull/23550#issuecomment-1407316708
@TeslaCN @terrymanu can you take a review of these changes? I agree to clarify JDK requirement on wiki and docs. Only the modules which uses `antlr-maven-plugin` will be impact. If the community is happy to accept this PR, I'm going to prepare for the antlr 4.10+ upgrade which could be - Upgarde `<antlr4.version>` to `4.10.1` - Run `antlr-maven-plugin` only in `jdk11+` profile - In `jdk8` profile, try to add the antlr generation directoy as source codes directory. if not, fail the building with the message `Please use JDK 11 to re-build artifact to generate the anltr codes` any thought? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
