azexcy opened a new pull request, #23808:
URL: https://github.com/apache/shardingsphere/pull/23808
Changes proposed in this pull request:
- Migration support for tables without primary key
- Add E2E IT test
Tables without primary keys currently do not support data consistency
checks, it's will be ignored.
eg.
```
mysql> show MIGRATION check status 'j01018f00c0a95509ff8e7066269c23bb165e';
+--------------+--------+---------------------+-------------------+------------------+----------------+------------------+---------------------------------------------------------------------------+
| tables | result | finished_percentage | remaining_seconds |
check_begin_time | check_end_time | duration_seconds | error_message
|
+--------------+--------+---------------------+-------------------+------------------+----------------+------------------+---------------------------------------------------------------------------+
| t_order_item | false | 0 | 0 |
| | 0 | Data consistency check are not
supported for tables without primary keys |
+--------------+--------+---------------------+-------------------+------------------+----------------+------------------+---------------------------------------------------------------------------+
1 row in set (7.31 sec)
```
---
Before committing this PR, I'm sure that I have checked the following
options:
- [ ] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
