azexcy commented on code in PR #23808:
URL: https://github.com/apache/shardingsphere/pull/23808#discussion_r1090207378
##########
kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/check/consistency/MigrationDataConsistencyChecker.java:
##########
@@ -77,12 +78,17 @@ public Map<String, DataConsistencyCheckResult> check(final
DataConsistencyCalcul
verifyPipelineDatabaseType(calculateAlgorithm, jobConfig.getTarget());
SchemaTableName sourceTable = new SchemaTableName(new
SchemaName(tableNameSchemaNameMapping.getSchemaName(jobConfig.getSourceTableName())),
new TableName(jobConfig.getSourceTableName()));
SchemaTableName targetTable = new SchemaTableName(new
SchemaName(tableNameSchemaNameMapping.getSchemaName(jobConfig.getTargetTableName())),
new TableName(jobConfig.getTargetTableName()));
+ progressContext.getTableNames().add(jobConfig.getSourceTableName());
Review Comment:
Because the table name need be set before return if the unique key isn's
exists
##########
kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/check/consistency/MigrationDataConsistencyChecker.java:
##########
@@ -77,12 +78,17 @@ public Map<String, DataConsistencyCheckResult> check(final
DataConsistencyCalcul
verifyPipelineDatabaseType(calculateAlgorithm, jobConfig.getTarget());
SchemaTableName sourceTable = new SchemaTableName(new
SchemaName(tableNameSchemaNameMapping.getSchemaName(jobConfig.getSourceTableName())),
new TableName(jobConfig.getSourceTableName()));
SchemaTableName targetTable = new SchemaTableName(new
SchemaName(tableNameSchemaNameMapping.getSchemaName(jobConfig.getTargetTableName())),
new TableName(jobConfig.getTargetTableName()));
+ progressContext.getTableNames().add(jobConfig.getSourceTableName());
Review Comment:
Yes, because the table name need be set before return if the unique key
isn's exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
