azexcy commented on code in PR #23808:
URL: https://github.com/apache/shardingsphere/pull/23808#discussion_r1090295332
##########
kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/check/consistency/DataConsistencyCheckResult.java:
##########
@@ -27,35 +27,40 @@
@ToString
public final class DataConsistencyCheckResult {
+ private final DataConsistencyCheckIgnoredType checkIgnoredType;
+
private final DataConsistencyCountCheckResult countCheckResult;
private final DataConsistencyContentCheckResult contentCheckResult;
- private final DataConsistencyCheckIgnoredType checkIgnoredType;
-
- private final boolean ignored;
-
public DataConsistencyCheckResult(final DataConsistencyCountCheckResult
countCheckResult, final DataConsistencyContentCheckResult contentCheckResult) {
+ checkIgnoredType = null;
this.countCheckResult = countCheckResult;
this.contentCheckResult = contentCheckResult;
- checkIgnoredType = null;
- ignored = false;
}
public DataConsistencyCheckResult(final DataConsistencyCheckIgnoredType
checkIgnoredType) {
this.checkIgnoredType = checkIgnoredType;
- ignored = true;
countCheckResult = null;
contentCheckResult = null;
}
+ /**
+ * Is ignored.
+ *
+ * @return ignored or not
+ */
+ public boolean isIgnored() {
+ return checkIgnoredType != null;
+ }
Review Comment:
The class is `final`, method can't add `final`, otherwise checkstyle will
failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
