linghengqian commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703258183
##########
infra/reachability-metadata/src/main/resources/META-INF/native-image/org.apache.shardingsphere/generated-reachability-metadata/resource-config.json:
##########
@@ -2794,8 +2782,5 @@
"bundles":[{
"name":"com.microsoft.sqlserver.jdbc.SQLServerResource",
"locales":["zh-CN"]
- }, {
- "name":"sun.text.resources.cldr.FormatData",
- "locales":["en"]
}]
}
Review Comment:
- This is what the GraalVM Tracing Agent ( under GraalVM CE For JDK 22.0.2 )
does after executing `./mvnw -PgenerateMetadata -DskipNativeTests -e -T1C clean
test native:metadata-copy` to fix nativeTest.
- As discussed earlier, the entire JSON file in the same folder is
automatically generated and is considered to be unchangeable by
https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-jdbc/graalvm-native-image/
. CC @terrymanu .
- Do you think we need to add checkstyle or spotless rules to automatically
detect and add blank lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
