linghengqian commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703259887
##########
pom.xml:
##########
@@ -987,10 +987,6 @@
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
</dependency>
- <dependency>
- <groupId>ch.qos.logback</groupId>
- <artifactId>logback-classic</artifactId>
- </dependency>
Review Comment:
So far, the current PR seems to be ready for the next review. In the current
PR, Shardingsphere Proxy uses Logback with runtime scope, while ShardingSphere
JDBC only provides Logback with provided scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
