Re: [PR] Block `shardingsphere-logging-core` from passing `logback-classic` dependencies to downstream modules [shardingsphere]

Sun, 04 Aug 2024 20:44:37 -0700 


linghengqian commented on code in PR #32389:
URL: https://github.com/apache/shardingsphere/pull/32389#discussion_r1703502276


##########
parser/sql/dialect/doris/pom.xml:
##########
@@ -36,5 +36,11 @@
             <artifactId>shardingsphere-infra-database-doris</artifactId>
             <version>${project.version}</version>
         </dependency>
+        
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <scope>test</scope>

Review Comment:
   - See 
https://github.com/apache/shardingsphere/pull/32389#discussion_r1703490403 . 
After I removed the declaration of `ch.qos.logback:logback-classic` here, I 
didn't see any logback dependencies. Without explicit declaration, the 
`parser/sql/dialect/doris/src/test/resources/logback-test.xml` of this module 
will be useless. Where does this picture come from?
   - 
![image](https://github.com/user-attachments/assets/f1eaf8f1-2036-45aa-9b3c-26c5dd4d8788)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to