ym0506 commented on PR #38685: URL: https://github.com/apache/shardingsphere/pull/38685#issuecomment-4550345428
Addressed the latest review in commit `3678c275`. Changes: - Added a core rewrite-context regression verifying that after an encrypt table rule item is dropped from `EncryptRuleConfiguration`, `EncryptSQLRewriteContextDecorator` no longer registers rewrite token generators for `INSERT` on that table. - Added a `distsql_rdl` E2E case for `DROP ENCRYPT RULE` -> `LOAD SINGLE TABLE *.*` -> `SHOW ENCRYPT TABLE RULE`, asserting the dropped rule remains absent. - Added a `distsql_rdl` E2E case for `CREATE ENCRYPT RULE` -> `INSERT` while encrypted -> `DROP ENCRYPT RULE` -> `INSERT` after drop -> `LOAD SINGLE TABLE *.*`. The assertion checks that the pre-drop row is stored through the cipher column and the post-drop row stays plaintext with a null cipher column. Verified locally: - `xmllint --noout test/e2e/sql/src/test/resources/cases/rdl/e2e-rdl-create.xml test/e2e/sql/src/test/resources/cases/rdl/dataset/distsql_rdl/insert_after_drop_encrypt_rule.xml` - `./mvnw -pl features/encrypt/core -am -DskipITs -Djacoco.skip=true -Dspotless.apply.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -DskipNativeImageTest=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=EncryptSQLRewriteContextDecoratorTest test` - `./mvnw spotless:check -Pcheck -pl features/encrypt/core` - `./mvnw checkstyle:check -Pcheck -pl features/encrypt/core` - `./mvnw apache-rat:check -Pcheck -pl test/e2e/sql` GitHub Actions is running the full PR matrix for the pushed commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
