ym0506 commented on PR #38685: URL: https://github.com/apache/shardingsphere/pull/38685#issuecomment-4554031802
Addressed the latest whitespace review in commit `febb648f`. The post-drop encrypt rewrite regression is now folded into the existing `assertDecorateWithoutEncryptTable()` test instead of adding a separate test/helper pair. This keeps the coverage while avoiding newly added blank separator lines that Spotless preserves but `git diff --check` reports as trailing whitespace. Verified locally: - `git diff --check origin/master...HEAD` - `./mvnw spotless:check -Pcheck -pl features/encrypt/core` - `./mvnw checkstyle:check -Pcheck -pl features/encrypt/core` - `./mvnw -pl features/encrypt/core -am -DskipITs -Djacoco.skip=true -Dspotless.apply.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -DskipNativeImageTest=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=EncryptSQLRewriteContextDecoratorTest test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
