ym0506 commented on PR #38685: URL: https://github.com/apache/shardingsphere/pull/38685#issuecomment-4561334738
Addressed the latest review in commit `669ecfe2`. Changes: - Split the post-drop encrypt rewrite regression into a dedicated `assertDecorateWithoutDroppedEncryptTable()` test. - Restored `assertDecorateWithoutEncryptTable()` so it only covers the existing no-encrypt-table scenario and invokes `decorate(...)` once. - Kept the checkstyle suppression scoped only around the method separator/declaration because Spotless preserves indented member-separator blank lines while `git diff --check` rejects newly added trailing whitespace on those separator lines; Checkstyle is re-enabled at the start of the test body. Verified locally: - `git diff --check 6d761e53884e37bff7af1d2047221088565bbbdc` - `xmllint --noout test/e2e/sql/src/test/resources/cases/rdl/e2e-rdl-create.xml test/e2e/sql/src/test/resources/cases/rdl/dataset/distsql_rdl/create_recreated_encrypt_rule.xml test/e2e/sql/src/test/resources/cases/rdl/dataset/distsql_rdl/insert_after_drop_encrypt_rule.xml` - `./mvnw spotless:check -Pcheck -pl features/encrypt/core` - `./mvnw checkstyle:check -Pcheck -pl features/encrypt/core,mode/type/standalone/core` - `./mvnw -pl features/encrypt/core,mode/type/standalone/core -am -DskipITs -Djacoco.skip=true -Dspotless.apply.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -DskipNativeImageTest=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=EncryptSQLRewriteContextDecoratorTest,StandaloneMetaDataManagerPersistServiceTest test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
