somiljain2006 commented on PR #38810:
URL: https://github.com/apache/shardingsphere/pull/38810#issuecomment-4638609609
Thanks for the detailed review.
I've updated the fix to address the generated-key retrieval path before
execution rather than only filtering values in UpdateResponseHeader.
Changes made:
* Gated RETURN_GENERATED_KEYS using GeneratedKeyContext.isGenerated() in
ProxySQLExecutor, so explicit auto-increment values no longer request generated
keys from the backend.
* Applied the same generated/explicit distinction to the federation
execution path.
* Kept the response-side filtering as a safeguard to avoid propagating
explicit values as generated keys.
* Added regression coverage in ProxySQLExecutorTest to verify the
generated-key decision is propagated through StatementOption.
* Added callback-level regression tests in ProxyJDBCExecutorCallbackTest to
verify:
* explicit auto-increment values do not invoke Statement#getGeneratedKeys()
* genuine generated-key inserts still invoke Statement#getGeneratedKeys()
All related tests are passing locally, including:
* StandardDatabaseProxyConnectorTest
* ProxySQLExecutorTest
* ProxyJDBCExecutorCallbackTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
