somiljain2006 commented on PR #38810:
URL: https://github.com/apache/shardingsphere/pull/38810#issuecomment-4756671294
Thank you for the detailed review.
I believe the latest revision addresses the remaining DEFAULT case that you
identified.
Changes made:
* Added handling for `CommonExpressionSegment` in
`ProxySQLExecutor.isReturnGeneratedKeysFromExpression(...)` and delegated the
decision to the dialect-generated-key contract:
`generatedKeyOption.isGeneratedKeyTriggerValue(expr.getText())`.
* Extended `MySQLGeneratedKeyOption` so that `DEFAULT` is treated as a
generated-key trigger value alongside the existing `NULL` and `0` handling.
* Added regression coverage using the production parser expression shape:
`new CommonExpressionSegment(0, 0, "DEFAULT")`,
which matches the MySQL parser output path referenced in the review.
* Added focused dialect-option tests covering:
* explicit non-magic values (e.g. `-3`)
* `NULL`
* `0`
* `DEFAULT`
The intention was to keep MySQL/MariaDB-specific semantics inside the
dialect-generated-key option rather than introducing additional
dialect-specific checks in the shared proxy executor.
Could you please take another look at the latest head and let me know if
there is still a specific DEFAULT path that remains uncovered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
