somiljain2006 commented on PR #38810:
URL: https://github.com/apache/shardingsphere/pull/38810#issuecomment-4639935862
Thanks for the detailed review.
I've updated the implementation to distinguish explicit non-special values
from explicit values that still trigger AUTO_INCREMENT generation in
MySQL/MariaDB.
Changes made:
- Kept generated-key suppression for explicit nonspecial values such as -3.
- Preserved generated-key handling for explicit NULL and 0, which continue
to request database-side AUTO_INCREMENT generation.
- Applied the same logic consistently to both the normal Proxy execution
path and the federation execution path.
- Added regression coverage for:
- Explicit nonspecial value *-3* returns no generated key
- Explicit *NULL* returns a generated key
- Parameter-bound nonspecial value *-3* returns no generated key
- Parameter-bound *0* returns a generated key
- Existing generated-key behavior remains covered by the callback-level
tests.
All related tests are passing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
