ym0506 commented on PR #38449: URL: https://github.com/apache/shardingsphere/pull/38449#issuecomment-4727837014
I pushed a follow-up revision addressing the shared metadata revise path in `ShardingIndexReviser`. This revision: - extends the shared `IndexReviser` contract with generic `TableMetaData` propagation, without adding target-dialect-specific concepts to the shared API; - switches `ShardingIndexReviser` to candidate-aware recovery for generated actual index names; - preserves exact logical index names such as `foo_h12345678` / `foo_t12345678` when they are not proven to be ShardingSphere-generated names; - adds regressions for truncated named index recovery, exact suffix-like logical names, and recovery through the shared `IndexReviseEngine` path outside the MySQL merged-result path. Local verification passed with: - `./mvnw -pl infra/common,features/encrypt/core,features/sharding/core -am -Pcheck -DskipTests -DskipITs spotless:check` - `./mvnw -pl infra/common,features/encrypt/core,features/sharding/core -am -Pcheck -DskipTests -DskipITs checkstyle:check` - `./mvnw -pl infra/common,features/encrypt/core,features/sharding/core -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=IndexReviseEngineTest,TableMetadataReviseEngineTest,SchemaMetaDataReviseEngineTest,EncryptIndexReviserTest,ShardingIndexReviserTest test` GitHub Actions are currently queued for the latest commit. I will inspect the logs if any checks fail. Please take another look when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
