ym0506 commented on PR #38449: URL: https://github.com/apache/shardingsphere/pull/38449#issuecomment-4748057817
I pushed a follow-up revision at `768e43873` addressing the latest shared metadata revise blocker. This revision: - propagates generic schema metadata revision candidates through the shared metadata revise path, from `GenericSchemaBuilderMaterial` to `IndexReviser`; - lets `ShardingIndexReviser` recover generated actual index names using logical candidate table metadata while keeping the shared API target-agnostic; - wires current database schemas as candidate metadata into metadata reload, persist, and pushdown metadata rebuild paths; - adds the requested shared-path regression where both `tbl_0` and `tbl_1` use `IndexMetaDataUtils.getActualIndexName(logicIndexName, actualTableName, PostgreSQL)` and the result restores the full logical index name. Local verification passed with: - `./mvnw -pl features/sharding/core -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ShardingIndexReviserTest#assertReviseThroughSharedIndexReviseEngineWithAllTruncatedNamedActualIndexNamesUsingRevisionCandidates test` - `./mvnw -pl infra/common,mode/core,features/encrypt/core,features/sharding/core -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ShardingSphereDatabaseFactoryTest,MetaDataContextsFactoryTest,MetaDataReviseEngineTest,IndexReviseEngineTest,TableMetadataReviseEngineTest,SchemaMetaDataReviseEngineTest,EncryptIndexReviserTest,ShardingIndexReviserTest test` - `./mvnw -pl features/sharding/core,features/encrypt/core,kernel/single/core -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ShardingMetaDataReviseEngineTest,EncryptMetaDataReviseEngineTest,SingleMetaDataReviseEngineTest test` - `./mvnw -pl infra/common,mode/core,features/sharding/core -am -Pcheck -DskipTests -DskipITs spotless:check` - `./mvnw -pl infra/common,mode/core,features/sharding/core -am -Pcheck -DskipTests -DskipITs checkstyle:check` Note: Mockito inline tests fail inside my local Codex sandbox before assertions because Byte Buddy cannot attach to the sandboxed JVM. I reran the Mockito-based Maven tests outside the sandbox and they passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
