ym0506 commented on PR #38449: URL: https://github.com/apache/shardingsphere/pull/38449#issuecomment-4748693079
Follow-up pushed at `15acb25cb`. This revision resolves the latest `master` conflicts and keeps the schema metadata revision candidate propagation on top of the current upstream metadata rebuild paths. Summary: - merged latest `master` into the PR branch, so the previous `DIRTY` conflict state is gone; - kept upstream `DatabaseIdentifierContext` handling and the direct-schema `create(..., schemas)` overload; - added a separate `createWithSchemaMetaDataRevisionCandidates(...)` path to avoid overloading ambiguity between final schemas and revision candidate schemas; - propagated schema metadata revision candidates through the current rebuild/reload/persist/pushdown paths, including `MetaDataContextsFactory`, `ContextManager`, `DatabaseMetaDataPersistFacade`, pushdown refresher loaders, and cluster/standalone metadata manager persist services. Local verification passed with: - `./mvnw -pl infra/common,mode/core,mode/type/cluster/core,mode/type/standalone/core,features/encrypt/core,features/sharding/core,kernel/single/core -am -Pcheck -DskipTests -DskipITs spotless:check` - `./mvnw -pl infra/common,mode/core,mode/type/cluster/core,mode/type/standalone/core,features/encrypt/core,features/sharding/core,kernel/single/core -am -Pcheck -DskipTests -DskipITs checkstyle:check` - `./mvnw -pl infra/common,mode/core,mode/type/cluster/core,mode/type/standalone/core,features/encrypt/core,features/sharding/core,kernel/single/core -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=ShardingSphereDatabaseFactoryTest,MetaDataContextsFactoryTest,MetaDataReviseEngineTest,IndexReviseEngineTest,TableMetadataReviseEngineTest,SchemaMetaDataReviseEngineTest,EncryptIndexReviserTest,ShardingIndexReviserTest,ShardingMetaDataReviseEngineTest,EncryptMetaDataReviseEngineTest,SingleMetaDataReviseEngineTest test` GitHub Actions for the latest head have completed successfully: `87/87` checks passed. Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
