thswlsqls opened a new pull request, #39209:
URL: https://github.com/apache/shardingsphere/pull/39209
Fixes #39206.
Changes proposed in this pull request:
- `AlterEncryptRuleExecutor.buildToBeDroppedRuleConfiguration()` now
synthesizes the post-alter configuration (unchanged tables plus the altered
ones) before calling `UnusedAlgorithmFinder.findUnusedEncryptor`, so encryptors
orphaned by an ALTER are dropped.
- Previously it ignored its `toBeAlteredRuleConfig` parameter and checked
the pre-alter configuration, where every encryptor is still in use, so nothing
was dropped and `assist_*` / `like_*` encryptors leaked.
- Aligns the ALTER encrypt path with the sibling `AlterMaskRuleExecutor`,
which already merges unchanged and altered tables; `DropEncryptRuleExecutor`
was already correct.
- Adds unit tests for assisted/like removal (encryptors dropped) and an
unchanged column definition (nothing dropped).
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. <!-- module-scoped install -pl
features/encrypt/distsql/handler -am passed; spotless/checkstyle/apache-rat
clean -->
- [ ] I have made corresponding changes to the documentation. <!-- no
user-facing docs affected; behavior fix -->
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
