thswlsqls commented on PR #39209: URL: https://github.com/apache/shardingsphere/pull/39209#issuecomment-5148167715
@terrymanu Thanks for the review, and for the reproduction guard. You were right — `toBeAlteredTableNames` was a plain list, so the exclusion compared case-sensitively while `EncryptRule` keys its tables through `CaseInsensitiveMap`, leaving the old definition in place and keeping the encryptors referenced. It is now a `CaseInsensitiveSet`, and `assertBuildToBeDroppedRuleConfigurationWhenAlteredTableNameCaseDiffers` covers `T_ENCRYPT` against a persisted `t_encrypt`, asserting the two encryptors are dropped; that test fails on the previous code and passes now (8 tests). Also rebased onto master to clear the release-note conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
