terrymanu commented on issue #27071: URL: https://github.com/apache/shardingsphere/issues/27071#issuecomment-5328965706
Hi @FlyingZC, thanks for raising this. This enhancement has already been implemented on the current master, so this issue can be closed. All five statements listed in this issue now parse successfully on current master: - `CREATE OR REPLACE TRIGGER ... AFTER CREATE ON DATABASE` is covered by the `systemTrigger` rule in `parser/sql/engine/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4`; - `CREATE OR REPLACE PACKAGE ... AUTHID DEFINER` and `TYPE ... INDEX BY PLS_INTEGER` are covered by `invokerRightsClause` (`AUTHID (CURRENT_USER | DEFINER)`) and the collection type rule `INDEX BY (PLS_INTEGER | ...)`; - the DML triggers with the `WHEN` clause, `PRAGMA EXCEPTION_INIT`, cursor `FOR UPDATE OF`, and multi-column `UPDATE OF Sal, Job` also parse without exceptions. The support was mainly delivered by #30808 (Oracle trigger parsing cases) and #39286 (Oracle database object DDL parsing), with regression cases in `test/it/parser/src/main/resources/sql/supported/ddl/create-trigger.xml` and `create-package.xml`. I verified the five exact statements from this issue against current master, and all of them parse successfully. I am closing this issue as resolved. If you find any of these statements still failing on a version that includes #39286, please feel free to reopen with the error details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
