terrymanu commented on issue #27072: URL: https://github.com/apache/shardingsphere/issues/27072#issuecomment-5328970151
Hi @FlyingZC, thanks for reporting this. The parsing support requested here is already available on the current master, so we can close this issue as completed. Oracle system-trigger parsing, including `AFTER SUSPEND ON DATABASE`, was added by #29643: the `databaseEvent` rule in `parser/sql/engine/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4` now includes `AFTER SUSPEND`, and the existing `createTrigger` / `systemTrigger` / `triggerBody` rules already cover `CREATE OR REPLACE TRIGGER ... ON DATABASE BEGIN ... END;`, the `DECLARE` section, and `PRAGMA AUTONOMOUS_TRANSACTION`. The existing `create_trigger_with_logon` case in `test/it/parser/src/main/resources/sql/supported/ddl/create-trigger.xml` verifies the same system-trigger shape. One small gap remains: there is no dedicated `AFTER SUSPEND` SQL test case yet. A small PR adding the two SQL statements from this issue to `create-trigger.xml` would be welcome. I am closing this issue as completed. Feel free to reopen it if you can still reproduce a parse failure on a version that includes #29643. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
