terrymanu commented on issue #27070: URL: https://github.com/apache/shardingsphere/issues/27070#issuecomment-5329000022
Hi @FlyingZC, thanks for reporting this. This has already been implemented on the current master, so we can close this issue as completed. The trigger parsing was delivered by #29604, #29610, #29643 and #29604/#29654 (milestone 5.5.0), which also closed the sibling task #27119 filed under the same parent #26878. The current grammar covers `CREATE (OR REPLACE)? TRIGGER` with simple DML triggers (`BEFORE/AFTER/INSTEAD OF`, `DELETE OR UPDATE OF column`, `FOR EACH ROW`), compound DML triggers, and system triggers (`BEFORE DROP ON schema`, `AFTER LOGON ON DATABASE`, etc.), see `PLSQL.g4` (`createTrigger` and `plsqlTriggerSource`) in `parser/sql/engine/dialect/oracle`. Corresponding Oracle SQL cases were added in `test/it/parser/src/main/resources/sql/supported/ddl/create-trigger.xml`. Please verify with a 5.5.0+ build. If any specific trigger syntax still fails to parse, feel free to open a new issue with the exact SQL, and we will handle it there. Thanks again for your contribution to the Oracle parsing enhancement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
