schizophrenicmaniac commented on PR #40212: URL: https://github.com/apache/shardingsphere/pull/40212#issuecomment-6265511300
@terrymanu Thanks, I pushed a commit for all five. 1. The WHERE collection doesn't build AND predicates any more. It goes through `ExpressionExtractor.extractAllExpressions`, which only splits on AND/OR, and checks each comparison, IN and BETWEEN once, so the work grows linearly with the condition. I added a test with 16 `(id=? OR k=?)` groups joined by AND. 2. `resolveUnspecifiedParameterValues` now has `@HighFrequencyInvocation`, and `getColumnNamesOfInsertStatement` builds the list with a loop instead of a Stream. 3. Both parameters are renamed to `params` and the `ifPresent` lambda is now `columnType`. The `Optional#map` lambdas are unchanged. 4. `containsUnspecifiedParameterValue` takes `Collection<Object>`. 5. The three constructor calls at :163, :198 and :233 now keep the first arguments on the opening line and wrap after a comma. I didn't touch :180 or :189. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
