schizophrenicmaniac commented on PR #40212: URL: https://github.com/apache/shardingsphere/pull/40212#issuecomment-6474658597
@terrymanu Thanks, I pushed a commit for all three. 1. NOT IN and NOT BETWEEN are now skipped the same way the sharding condition generators skip them, so a parameter used there stays OID 0 text and PostgreSQL picks the operator as it does on master. There's a first-Bind test for `id NOT IN ($1)` and `id NOT BETWEEN $1 AND $1`. 2. The missing-table test now supplies the sharding rule attribute and an existing schema, and checks that `containsTable` is called and `getTable` isn't, so it fails if the guard is removed. 3. I removed `ShardingStrategyColumnRuleAttributeTest`. The `ShardingRuleTest` case with the real rule is still there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
