schizophrenicmaniac commented on PR #40309: URL: https://github.com/apache/shardingsphere/pull/40309#issuecomment-6338782910
@terrymanu Thanks for the review, all three are fixed in the latest commit. 1. Parameters that can't be matched to a column are now described as VARCHAR with a length of 32765 (the Firebird VARCHAR maximum), so the LENGTH item is always written. The INSERT ... SELECT test now requests LENGTH and checks it. 2. For INSERT ... SELECT, the where segments now come from the inner SelectStatementContext through the same UNION traversal used for a plain SELECT. I added a three-branch INSERT ... SELECT test that expects INTEGER/BLOB/INTEGER. 3. Removed both line comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
