schizophrenicmaniac commented on PR #40309: URL: https://github.com/apache/shardingsphere/pull/40309#issuecomment-6606044143
@terrymanu Thanks, both are fixed in the latest commit. 1. Parameters in `col IN (?, ...)` are now matched to the column the same way BETWEEN bounds are. For an INTEGER key they're described as INTEGER, so a client using setLong(10) sends 10 instead of "10" and gets the same HASH_MOD route as INSERT ... VALUES. For a NUMERIC/DECIMAL column their positions are recorded, so the execute path converts them back to numbers. assertDescribeInsertSelectInParameters covers `INSERT INTO foo_tbl (id) SELECT id + 2 FROM foo_tbl WHERE id IN (?, ?)`. 2. Added @Nullable to columnNames in createInsertColumnsSegment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
