schizophrenicmaniac commented on PR #40309: URL: https://github.com/apache/shardingsphere/pull/40309#issuecomment-6450234332
@terrymanu Thanks, all four are fixed in the latest commit. 1. A parameter inside CAST(? AS type) is now described with the type and length it's cast to, so CAST(? AS VARCHAR(20)) comes back as VARCHAR(20) instead of VARCHAR(32765). The Firebird CAST visitor was dropping the parameter marker from the function arguments, so it now keeps it, and the prepare executor picks up CAST types from the select list (including UNION branches), WHERE and UPDATE SET. Unknown type names (domains, for example) still fall back to VARCHAR. assertDescribeInsertSelectCastParameters requests LENGTH and checks INTEGER and VARCHAR with length 20. 2. Moved processUnknownParameter after the helpers called before it. 3. Put the return in isShardingInsertWithReturning back on one line. 4. Added @HighFrequencyInvocation to ShardingDMLResultMerger.merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
