totalo commented on a change in pull request #10840:
URL: https://github.com/apache/shardingsphere/pull/10840#discussion_r655150382
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/SchemaBuilder.java
##########
@@ -126,38 +144,38 @@ private static void appendDialectRemainTables(final
DialectTableMetaDataLoader d
}
}
}
-
- private static void appendDefaultRemainTables(final SchemaBuilderMaterials
materials, final ShardingSphereSchema schema) throws SQLException {
- Collection<String> existedTableNames =
getExistedTables(materials.getRules(), schema);
- for (Entry<String, DataSource> entry :
materials.getDataSourceMap().entrySet()) {
+
+ private static void appendDefaultRemainTables(final SchemaBuilderMaterials
materials, final Map<String, TableMetaData> tables) throws SQLException {
+ Collection<String> existedTableNames =
getExistedTables(materials.getRules(), tables);
+ for (Map.Entry<String, DataSource> entry :
materials.getDataSourceMap().entrySet()) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
