totalo commented on a change in pull request #10840:
URL: https://github.com/apache/shardingsphere/pull/10840#discussion_r655886348
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/rule/builder/ShardingSphereRulesBuilder.java
##########
@@ -103,13 +104,15 @@ private static void
appendDefaultKernelSchemaRuleConfigurationBuilder(final Map<
}
@SuppressWarnings("rawtypes")
- private static void
appendDefaultKernelGlobalRuleConfigurationBuilder(final Map<RuleConfiguration,
GlobalRuleBuilder> builders) {
+ private static Map<RuleConfiguration, GlobalRuleBuilder>
appendDefaultKernelGlobalRuleConfigurationBuilder(final Map<RuleConfiguration,
GlobalRuleBuilder> builders) {
Review comment:
In my local as well as the process of ci, I found that produce abnormal
`ConcurrentModificationException`, see the code found here has a todo, and
multi-threaded read or add a `builder`, Can lead to a
`ConcurrentModificationException`, so I just dropped in to repair the him.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
